Add tests for controller restart behaviour.#71
Merged
Conversation
Assisted-By: devx/904563b8-dbee-48b0-9726-f036df3ed96d
samuel-williams-shopify
force-pushed
the
restart-behaviour-tests
branch
from
d31d992 to
d2e2a47
Compare
samuel-williams-shopify
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locks in the current
#restartbehaviour before refactoring signal/restart handling. Test-only, additive.Coverage added (
with "#restart")restarton a running controller creates a new container and swaps it in (the container object is replaced), stopping the old one.restartstarts a container if none is running.Note
Restart is a replace operation (blue-green): children are recreated wholesale, so restart does not propagate into live children/sub-controllers. Accordingly this PR intentionally does not pin any cross-thread
Thread#raise(Restart)propagation behaviour — that path (Child#restart!) is a candidate for removal, and propagation semantics belong toreload, notrestart.Reload reconciliation coverage (add/remove keyed children) is handled in a separate PR.